Staging/max32670 #2238
Open
Staging/max32670 #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
For consistency reasons, to match the other Maxim targets. Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
dbogdan
requested review from
buha,
CiprianRegus,
amiclaus,
rbolboac and
danmois
as code owners
CiprianRegus
reviewed
Jul 3, 2024
Comment on lines
+65
to
+90
| static int32_t _max_spi_config_pins(struct no_os_spi_desc *desc) | ||
| { | ||
| struct max_spi_init_param *eparam; | ||
| mxc_gpio_cfg_t spi_pins; | ||
|
|
||
| eparam = desc->extra; | ||
|
|
||
| switch(desc->device_id) { | ||
| case 0: | ||
| spi_pins = gpio_cfg_spi0; | ||
| break; | ||
| case 1: | ||
| spi_pins = gpio_cfg_spi1; | ||
| break; | ||
| case 2: | ||
| spi_pins = gpio_cfg_spi2; | ||
| break; | ||
| default: | ||
| return -EINVAL; | ||
| } | ||
|
|
||
| spi_pins.vssel = eparam->vssel; | ||
| MXC_GPIO_Config(&spi_pins); | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
May be worth mentioning in the commit message that MAX32670 only has 1 CS per SPI instance (which is already included in the gpio_cfg_spi pin config structs), so we don't need to configure it independently, as for the other Maxim drivers.
amiclaus
reviewed
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
MAX32670 VDDIO selection support for SPI and UART.
PR Type
PR Checklist