cmake: Replace deprecated exec_program() with execute_process() #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be nice to point to the cmake doc in the commit message. https://cmake.org/cmake/help/latest/command/exec_program.html since we are |
rgetz
approved these changes
Dec 24, 2024
Make sense. I will update the commit message. Thanks, Robin! |
dNechita
force-pushed
the
cmake_uninstall_update
branch
from
dc2317f to
b076a17
Compare
|
V2:
|
exec_program() has been deprecated since version 3.0. See here: https://cmake.org/cmake/help/latest/command/exec_program.html Invoking the uninstall target causes warning messages about using deprecated exec_program() such as: "sudo make uninstall -- Uninstalling /usr/lib/x86_64-linux-gnu/pkgconfig/libiio.pc CMake Warning (dev) at cmake_uninstall.cmake:49 (exec_program): Policy CMP0153 is not set: The exec_program command should not be called. Run "cmake --help-policy CMP0153" for policy details. Use the cmake_policy command to set the policy and suppress this warning. " Used cmake version 3.28.3. Signed-off-by: Dan Nechita <dan.nechita@analog.com>
dNechita
force-pushed
the
cmake_uninstall_update
branch
from
b076a17 to
55a348f
Compare
cristina-suteu
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
exec_program() has been deprecared. This PR updates a cmake file to use execute_process() instead.
PR Type
PR Checklist