-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #32 from amq92/amq92-patch-contributing
Amq92 patch contributing
- Loading branch information
Showing
2 changed files
with
38 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Contributing to Simple Slurm | ||
|
||
We welcome contributions! Before submitting changes, please follow these guidelines: | ||
|
||
## Reporting Issues | ||
- Check existing issues to avoid duplicates. | ||
- Include a **minimal reproducible example** for bugs. | ||
- If possible specify your Slurm cluster setup (*e.g.*, Slurm version, Linux distro). | ||
|
||
## Submitting Pull Requests | ||
1. **Fork the repository** and create a feature branch. | ||
```bash | ||
git checkout -b my-feature | ||
``` | ||
3. Ensure code passes: | ||
```bash | ||
ruff check . # Linting | ||
ruff format . # Formatting | ||
python -m unittest -v # Run unit tests | ||
``` | ||
4. Test/validate changes (see [Testing](#testing)). | ||
5. Update documentation if needed. | ||
6. Open a PR with a clear description of changes and test results. | ||
|
||
## Code Style | ||
- Format code with [`ruff`](https://docs.astral.sh/ruff/). | ||
- Add type hints for new functions/methods. | ||
- Keep docstrings consistent with existing code. | ||
|
||
## Testing | ||
- Testing on a real Slurm cluster is **highly desired**. | ||
- Add unit tests to validate any change in functionality. | ||
|
||
## Questions? | ||
- Open a GitHub issue. | ||
- Tag [`@amq92`](https://github.com/amq92) in the discussion. | ||
|
||
Thank you for helping improve Simple Slurm! 🚀 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters