Skip to content

Commit

Permalink
refactor: raise minimum version from python 3.8 -> python 3.9
Browse files Browse the repository at this point in the history
This commit is expected to land at a time close to or after 2024-10-01,
following which Python 3.8 will be end-of-life. Several tools already
require a Python version >=3.9, which has caused dependency resolution
issues for some time now. Python 3.9 changed the workings of the type
system  quite substantially. This will allow for a higher code quality
going forwards.

BREAKING CHANGE: Python 3.8 is no longer supported as of this commit.

To migrate, update your system's Python version.
  • Loading branch information
Nytelife26 committed Jul 24, 2024
1 parent 2625c60 commit 18459e5
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 104 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ jobs:
strategy:
matrix:
# 5 versions / years of coverage
python: ["3.8", "3.9", "3.10", "3.11", "3.12", "pypy3.9", "pypy3.10"]
os: [ubuntu-latest, macos-13, windows-latest]
python: ["3.9", "3.10", "3.11", "3.12", "3.13", "pypy3.9", "pypy3.10"]
os: [ubuntu-latest, macos-latest-large, windows-latest]
steps:
- name: "[INIT] Checkout repository"
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ repos:
- id: markdownlint

- repo: https://github.com/abravalheri/validate-pyproject
rev: v0.15
rev: v0.18
hooks:
- id: validate-pyproject

Expand Down
97 changes: 8 additions & 89 deletions pdm.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions proselint/checks/restricted/elementary.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@

from __future__ import annotations

try:
from importlib.resources import files
except ImportError:
from importlib_resources import files
from importlib.resources import files

import proselint
from proselint.checks import CheckSpec, ReverseExistence
Expand Down
5 changes: 1 addition & 4 deletions proselint/checks/restricted/top1000.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@

from __future__ import annotations

try:
from importlib.resources import files
except ImportError:
from importlib_resources import files
from importlib.resources import files

import proselint
from proselint.checks import CheckSpec, ReverseExistence
Expand Down
Loading

0 comments on commit 18459e5

Please sign in to comment.