Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Data Stores column types to float #316

Conversation

ddeli
Copy link
Collaborator

@ddeli ddeli commented Feb 2, 2025

Although I specified type: 'float', double precision was used in the generated migration. This is because TypeORM chooses the most suitable type for float depending on the database engine used and thus automatically . If we explicitly want to have float in the database, a new migration must be created with type: 'real'

Signed-off-by: Deniz Deli <d.deli@campus.tu-berlin.de>
Copy link
Contributor

@flo0852 flo0852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Just for the future. If we would have a production system, it would be fatal to have the NOT NULL constraint, without a default value, because now the backend crashes, if there were already values in the table before

@flo0852 flo0852 merged commit e798a00 into dev Feb 2, 2025
3 checks passed
@ddeli ddeli deleted the 313-bugifx-change-datastores-column-types-to-support-comma-values branch February 3, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants