Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

209 frontend module alert overview page with alert table #238

Merged
merged 39 commits into from
Jan 19, 2025
Merged

209 frontend module alert overview page with alert table #238

merged 39 commits into from
Jan 19, 2025

Conversation

chrisklg
Copy link
Contributor

created alert panel component
created alert util to reuse this code for the alert panel

upgrade the loading spinner, I need a new issue to outsource this changes.

chrisklg added 20 commits January 10, 2025 17:42
@chrisklg
Merge remote-tracking branch 'origin/dev' into 209-frontend-module-al…
5894467 
…ert-overview-page-with-alert-table
@chrisklg
initial alert-page component
7a3b22c 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
Merge remote-tracking branch 'origin/dev' into 209-frontend-module-al…
a0ba53a 
…ert-overview-page-with-alert-table
@chrisklg
add route to new component
9dc0908 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
create generic alert utils file
d40019d 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
correct some missings issues
566bcb0 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
refactor code and include alert util
57ecfe9 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
create first version of alert component view
74c7a7c 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
initial loading-overlay component for custom loading
8c77a87 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
Merge remote-tracking branch 'origin/dev' into 209-frontend-module-al…
41d189c 
…ert-overview-page-with-alert-table
@chrisklg
edit custom loading spinner for data sync
0c906be 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
use shortenBytes to render sizes
d4a06b7 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
fixe sidenav for small window
115ad74 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
fix width of percentage
a3ce623 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
navigate from alert panel to alert page
67b7439 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
add destroy$ to abort request
dc9d9c9 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
panels get same height
29c3f99 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
add error handling loadAlerts
ac27910 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
add tests
1cfb386 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
cleanup code
0539cc8 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg chrisklg self-assigned this Jan 11, 2025
flo0852
flo0852 requested changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@flo0852 flo0852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice and cool ideas. Just some smaller things I found

@chrisklg
fixed unused code and some small issues
5c3c520 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@flo0852
Copy link
Contributor

flo0852 commented Jan 14, 2025

Blocked by Backend Issue

@chrisklg
Merge remote-tracking branch 'origin/dev' into 209-frontend-module-al…
80d3c29 
…ert-overview-page-with-alert-table
@chrisklg
add alertfilter
6ecfdc1 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
add alert filter type
58a6a60 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
edit filter logic for alert endpoint
897dba6 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
initial filter logic for datagrid
66c7261 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
change alert loading
78f4072 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
dropdown select severity type
ad02485 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
prepare multi select option
63e51e7 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
change alertType to dropdown filtering
1da3b4f 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
correct loading
74900e1 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
change alerts to observable
c91a47c 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
edit some tests
3e45496 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
remove wrong test casse
edc44d3 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
flo0852
flo0852 requested changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@flo0852 flo0852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice clean code, but filtering for Date doesn't work. And OrderBy doesnt work

@chrisklg
Merge remote-tracking branch 'origin/dev' into 209-frontend-module-al…
a521016 
…ert-overview-page-with-alert-table
@chrisklg
add sorting for datagrid
7a8acc4 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
fix some small issues
bc64585 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
@chrisklg
type filtering without sorting
7670b39 
Signed-off-by: Christoph Klingenberg <christoph-klingenberg@web.de>
flo0852
flo0852 approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@flo0852 flo0852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work

@chrisklg chrisklg merged commit 7bf087c into dev Jan 19, 2025
3 checks passed
@chrisklg chrisklg deleted the 209-frontend-module-alert-overview-page-with-alert-table branch January 19, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo0852 flo0852 flo0852 approved these changes

Assignees

@chrisklg chrisklg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisklg @flo0852