Skip to content

Commit

Permalink
fix for state check and enable debug
Browse files Browse the repository at this point in the history
  • Loading branch information
simonoff committed Sep 16, 2024
1 parent 0824934 commit 242cbf3
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions internal/controller/domain/domain_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,12 @@ func (r *DomainReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
mailgunDomain.Status.State = domainv1.DomainStateCreated
}

// No need to continue if domain already failed or activated
if mailgunDomain.Status.State == domainv1.DomainStateFailed || mailgunDomain.Status.State == domainv1.DomainStateActivated {
log.V(1).Info("Domain state check", "domain", domainName, "state", mailgunDomain.Status.State)
return ctrl.Result{}, nil
}

// we should to try create external DNS records if they are not created yet
if mailgunDomain.Spec.ExternalDNS != nil && *mailgunDomain.Spec.ExternalDNS && !mailgunDomain.Status.DnsEntrypointCreated {
log.V(1).Info("Create external dns records", "domain", domainName)
Expand All @@ -151,12 +157,6 @@ func (r *DomainReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
}
}

// No need to continue if domain already failed or activated
if mailgunDomain.Status.State == domainv1.DomainStateFailed || mailgunDomain.Status.State == domainv1.DomainStateActivated {
log.V(1).Info("Domain state check", "domain", domainName, "state", mailgunDomain.Status.State)
return ctrl.Result{}, nil
}

// try to search domain on Mailgun
log.V(1).Info("Get domain from mailgun before verification", "domain", domainName)
_, err := mg.GetDomain(ctx, domainName)
Expand Down Expand Up @@ -385,6 +385,8 @@ func (r *DomainReconciler) createDomain(ctx context.Context, domain *domainv1.Do

options.Password = password

// enable debug for a while
mailgun.Debug = true
domainResponse, err := mg.CreateDomain(ctx, domain.Spec.Domain, &options)
if err != nil {
log.Error(err, "unable to create mailgun domain", "response", domainResponse)
Expand Down

0 comments on commit 242cbf3

Please sign in to comment.