-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Docker support #183
add Docker support #183
Conversation
To summarize why this request will not be merged in Amon for the time being. The following is operated through cron jobs
This container will run the django app and the UI, but will not have the functionality above |
What's the point of adding a comment stating what needs to be fixed and then just closing it? Adding cron is super simple just add another container like this to handle the cron jobs. |
@OmgImAlexis Not going to fix it. If we add 1 more container, we will have a total of 3 - 1 for Amon, 1 for Mongo and 1 for cron, which at this point is deep into container management territory. |
That's how docker compose works though.. You don't need to maintain anything apart from the containers you build which would just be amon and the cron container. Seems more like you're just personally against using containers? |
@OmgImAlexis I know very well how docker works, this is how I earn a living. You said it right there You don't need to maintain anything apart from the containers you build. |
I just read this thread. Did I get it right, that amon won't offer a Dockerfile for on-premise hosting, which contains the amon Django app, or was this PR closed because the compose and caddy stuff? |
@kolletzki Docker support can still happen in the near future. A Dockerfile is not sufficient, because it opens a new layer of issues and support requests. The better approach is to have an automated docker build pipeline on release, similar to https://github.com/getsentry/docker-sentry/ In this case, as a user, you just do As for Docker Compose, I would not recommend it for cases where you have a database involved, because you need to add 1 more layer of bash scripts to check whenever the DB is up and running (https://docs.docker.com/compose/startup-order/) For Caddy - don't know much about that server. I know that they tried to monetize by shoving ads in the headers. Don't know what happened next. Can not stand behind or support a project like that. |
Thanks for the clarification! I've created #190 to keep track of this. |
To use this you need to run
docker-compose up -d --build
in the repo directory.This will setup caddy to proxy the static files, mongodb and the Amon process.
To change the domain used you'll need to edit the
Caddyfile
with your domain and make sure to add that mount point in thedocker-compose.yml
for/etc/opt/amon/amon.yml
.Closes #172