await command with _return_cmd True returns RunningCommand #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If _return_cmd is True, have __await__ return the RunningCommand object rather than a string representation. Fixes amoffat#743 Add test for this behavior and adjust existing tests because the baked test python instance is created with _return_cmd True.
amoffat
approved these changes
Jan 8, 2025
|
Good work, and thank you for including a test! Merging now, and will cut a release later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If _return_cmd is True, have await return the RunningCommand object rather than a string representation. Fixes #743
I'm having trouble getting the lint tox environment to pass; it fails even before my change wanting to reformat sh.py. I don't understand what the diff is trying to do so I don't know if it is a local environmental issue or something else.