Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

few small fixes #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

few small fixes #5

wants to merge 3 commits into from

Conversation

Notedop
Copy link
Contributor

@Notedop Notedop commented Jan 19, 2025

  • serial number can have 32 bytes max instead of 16, reads until 0XFF
  • manual code lookup did not support the regex codes, fixed this.

notedop added 3 commits January 18, 2025 16:28
fix 32 byte serial number
23571da 
serial numbers can be up to 32 bytes instead of 16 bytes
fix code lookup
4ec72eb 
manual code lookup did not get changed when implementing the regex support.
This is addressed by this commit
remove unused
5ab6515
@Notedop
Copy link
Contributor Author

Notedop commented Jan 22, 2025 •
edited
Loading

@amoamare can you merge this one as well and also create a new release of this build and publish it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Notedop