Improve exception handling and remove unnecessary else

src/rod/sdf/element.py

@@ -37,7 +37,7 @@ def deserialize_bool(data: str) -> bool:
         false_vals = {"0", "False", "false"}
         assert data in true_vals.union(false_vals)
 
-        return True if data in true_vals else False
+        return data in true_vals
 
     @staticmethod
     def serialize_float(data: float) -> str:

src/rod/sdf/sdf.py

@@ -101,8 +101,8 @@ def load(sdf: Union[pathlib.Path, str], is_urdf: Optional[bool] = None) -> Sdf:
         # Parse the SDF to dict
         try:
             xml_dict = xmltodict.parse(xml_input=sdf_string)
-        except Exception:
-            raise ValueError("Failed to parse 'sdf' argument")
+        except Exception as exc:
+            raise exc("Failed to parse 'sdf' argument")
 
         # Look for the top-level <sdf> element
         try:

src/rod/tree/tree_elements.py

@@ -34,16 +34,16 @@ class DirectedTreeNode(TreeElement):
     parent: Optional[DirectedTreeNode] = None
     children: List[DirectedTreeNode] = dataclasses.field(default_factory=list)
 
-    _source: Optional["rod.Link"] = dataclasses.field(default=None, repr=False)
+    _source: Optional[rod.Link] = dataclasses.field(default=None, repr=False)
 
     def name(self) -> str:
         return self._source.name
 
-    def pose(self) -> "rod.Pose":
+    def pose(self) -> rod.Pose:
         if self._source is not None and self._source.pose is not None:
             return self._source.pose
-        else:
-            return rod.Pose(relative_to="world")
+
+        return rod.Pose(relative_to="world")
 
     @property
     def tree_label(self) -> str:

src/rod/utils/gazebo.py

@@ -89,6 +89,7 @@ def process_model_description_with_sdformat(
                 text=True,
                 stdout=subprocess.PIPE,
                 stderr=subprocess.STDOUT,
+                check=True,
             )
 
         if cp.returncode != 0: