fix: add AppliedTradeTax to LogisticsServiceCharge (backport #34) #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding shipping costs as taxes with charge type "Actual" and VAT on the next line with charge type "On Previous Row Amount" or "On Previous Row Total" will produce an invalid e-invoice xml file with the extended profile.
The validation on import in erpnext will fail with the error
In order to fix this, output SpecifiedLogisticsServiceCharge with AppliedTradeTax.