Bluetooth: Mesh: add tf-m support for ble mesh #10
Conversation
samples/bluetooth/mesh_provisioner/nrf53_cpuapp_ns_overlay.conf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Board specific files can be moved under boards folder and keep board name in the file name without _overlay suffix: nrf5340dk_nrf5340_cpuapp_ns.conf. Then the sample can be build with just specifying board name. The file will be picked up by build system and merged with prf.conf of the sample. Same works for the network core I think. This will also not require special configuration (extra_args) for twister.
There was a problem hiding this comment.
I really want this option for any platform (including potential new Nordic's platforms), not only for nrf53 to avoid creation files for every new one. Probably it's worth to remove platform from file name and add tfm instead.
There was a problem hiding this comment.
But this is what we do even between thingy53 and nrf5340dk: https://github.com/nrfconnect/sdk-nrf/tree/main/samples/bluetooth/mesh/light_ctrl/boards
There was a problem hiding this comment.
If we want mesh always compile with CONFIG_BT_MESH_USES_TFM_PSA when TFM is supported, then default value for BT_MESH_CRYPTO_LIB choice should be updated, e.g.:
choice BT_MESH_CRYPTO_LIB
prompt "Crypto library selection for mesh security"
default BT_MESH_USES_TFM_PSA if BUILD_WITH_TFM
default BT_MESH_USES_TINYCRYPT
Not sure though if it is correct to use BUILD_WITH_TFM but not some other option.
There was a problem hiding this comment.
The overlay config will still be needed to disable settings and this should be fine.
There was a problem hiding this comment.
I still disagree with using any names other than the board name because this is how it is designed in Zephyr currently. You also won't need another target for twister and can just add nrf5340dk_nrf5340_cpuapp_ns to platform_allow.
alxelax
force-pushed
the
mesh_with_tfm_2
branch
2 times, most recently
from
839e000 to
e397e2d
Compare
There was a problem hiding this comment.
I still disagree with using any names other than the board name because this is how it is designed in Zephyr currently. You also won't need another target for twister and can just add nrf5340dk_nrf5340_cpuapp_ns to platform_allow.
alxelax
force-pushed
the
mesh_with_tfm_2
branch
2 times, most recently
from
af9cf8b to
fab0814
Compare
samples/bluetooth/mesh/README.rst
Outdated
| To run the application on nRF5340DK, a Bluetooth controller application must | ||
| also run on the network core. The :ref:`bluetooth-hci-rpmsg-sample` sample |
There was a problem hiding this comment.
| To run the application on nRF5340DK, a Bluetooth controller application must | |
| also run on the network core. The :ref:`bluetooth-hci-rpmsg-sample` sample | |
| To run the application on an :ref:`nrf5340dk_nrf5340`, a Bluetooth controller application must | |
| also run on the network core. The :ref:`bluetooth-hci-rpmsg-sample` sample |
| To run the application on nRF5340DK, a Bluetooth controller application must | ||
| also run on the network core. The :ref:`bluetooth-hci-rpmsg-sample` sample |
There was a problem hiding this comment.
| To run the application on nRF5340DK, a Bluetooth controller application must | |
| also run on the network core. The :ref:`bluetooth-hci-rpmsg-sample` sample | |
| To run the application on an :ref:`nrf5340dk_nrf5340`, a Bluetooth controller application must | |
| also run on the network core. The :ref:`bluetooth-hci-rpmsg-sample` sample |
| To run the application on nRF5340DK, a Bluetooth controller application must | ||
| also run on the network core. The :ref:`bluetooth-hci-rpmsg-sample` sample |
There was a problem hiding this comment.
| To run the application on nRF5340DK, a Bluetooth controller application must | |
| also run on the network core. The :ref:`bluetooth-hci-rpmsg-sample` sample | |
| To run the application on an :ref:`nrf5340dk_nrf5340`, a Bluetooth controller application must | |
| also run on the network core. The :ref:`bluetooth-hci-rpmsg-sample` sample |
This PR adds ability to build mesh with tf-m psa for platforms those support tf-m. Signed-off-by: Aleksandr Khromykh <aleksandr.khromykh@nordicsemi.no>
|
I close this PR. |
This PR adds ability to build mesh with tf-m psa
for platforms those support tf-m.