Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoders: support full 0-255 color range #1971

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Vixea
Copy link
Collaborator

@Vixea Vixea commented Feb 4, 2024

Tested with VAAPI, untested with NvEnc. Windows related changes soon.

@Meister1593
Copy link
Collaborator

Meister1593 commented Feb 4, 2024

Testing on pico 4 pro, some weird results:
First image is from steamvr view, second is with this pr, third is with this pr + gamma 1.1 (i found some mentions about this issue here)
It seems like by default it's making image way too dark, and if i would compare with some native headset, i think most correct one is with 1.1 gamma or prior to this PR?...
Not sure what is right or wrong there, but native headset (like vive) looks closer to 1.1 or without this pr

steamvr_void
srgb_1 0_gamma_steamvr_void
srgb_1 1_gamma_steamvr_void

@Vixea
Copy link
Collaborator Author

Vixea commented Feb 5, 2024

Ok after more testing it turns out not even the previous limited range is correct it may have been closer but it's not correct. A simple 1.1 gamma default change will get us closer to the previous results for the meantime before we can remove the bs that is doing color correction twice which is bound to have mistakes

@Vixea
Copy link
Collaborator Author

Vixea commented Feb 5, 2024

What we really need is someone to sit down and figure out if somewhere is implicitly using the wrong color space and if it's not just remove the above bs and or correct both

@Vixea Vixea force-pushed the full-range-color branch 2 times, most recently from 624f807 to 1b501ab Compare February 29, 2024 23:17
@Vixea Vixea requested a review from nowrep February 29, 2024 23:21
@Vixea Vixea force-pushed the full-range-color branch 2 times, most recently from fa072cb to fded7c2 Compare March 2, 2024 18:40
@Vixea Vixea force-pushed the full-range-color branch from fded7c2 to 36ef486 Compare March 2, 2024 18:42
@Vixea Vixea requested a review from zmerp March 2, 2024 18:47
@Vixea Vixea merged commit 9a7b369 into alvr-org:master Mar 4, 2024
6 checks passed
galister pushed a commit to galister/ALVR that referenced this pull request Mar 29, 2024
* support full 0-255 color range

* add amf full range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants