fix(server): handshake failure blocking retries (#1942) #592
zmerp
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
53 warnings
|
wiki
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, cmbrose/github-docs-to-wiki@v0.24. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`:
alvr/server/src/connection.rs#L343
warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
--> alvr/server/src/connection.rs:343:21
|
343 | let handshake = proto_socket.recv(HANDSHAKE_ACTION_TIMEOUT).or_else(|err| {
| _____________________^
344 | | server_data_lock.update_client_list(
345 | | client_hostname.clone(),
346 | | ClientListAction::SetConnectionState(ConnectionState::Disconnected),
... |
349 | | Err(err)
350 | | })?;
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
help: try
|
343 ~ let handshake = proto_socket.recv(HANDSHAKE_ACTION_TIMEOUT).map_err(|err| {
344 | server_data_lock.update_client_list(
...
348 |
349 ~ err
|
|
|
unused variable: `ui`:
alvr/dashboard/src/dashboard/components/setup_wizard.rs#L128
warning: unused variable: `ui`
--> alvr/dashboard/src/dashboard/components/setup_wizard.rs:128:18
|
128 | |ui| {
| ^^ help: if this is intentional, prefix it with an underscore: `_ui`
|
= note: `#[warn(unused_variables)]` on by default
|
|
accessing first element with `from_openvr_paths(paths_json).get(0)`:
alvr/server_io/src/openvrpaths.rs#L74
warning: accessing first element with `from_openvr_paths(paths_json).get(0)`
--> alvr/server_io/src/openvrpaths.rs:74:5
|
74 | from_openvr_paths(paths_json).get(0).cloned().to_any()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_openvr_paths(paths_json).first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
|
the borrowed expression implements the required traits:
alvr/launcher/src/main.rs#L763
warning: the borrowed expression implements the required traits
--> alvr/launcher/src/main.rs:763:24
|
763 | fs::create_dir_all(&installation_dir)?;
| ^^^^^^^^^^^^^^^^^ help: change this to: `installation_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
variable does not need to be mutable:
alvr/launcher/src/main.rs#L761
warning: variable does not need to be mutable
--> alvr/launcher/src/main.rs:761:9
|
761 | let mut installation_dir = data_dir().extended(VERSIONS_SUBDIR).extended(&release.tag);
| ----^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `buffer`:
alvr/launcher/src/main.rs#L759
warning: unused variable: `buffer`
--> alvr/launcher/src/main.rs:759:9
|
759 | let buffer = download(tx, "Downloading Streamer", &url, client).await?;
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable expression:
alvr/launcher/src/main.rs#L782
warning: unreachable expression
--> alvr/launcher/src/main.rs:782:5
|
765 | / match installation_type {
766 | | #[cfg(target_os = "linux")]
767 | | InstallationType::AppImage => {
768 | | installation_dir.push("ALVR-x86_64.AppImage");
... |
780 | | }
781 | | }
| |_____- any code following this `match` expression is unreachable, as all arms diverge
782 | Ok(())
| ^^^^^^ unreachable expression
|
= note: `#[warn(unreachable_code)]` on by default
|
|
unused import: `Permissions`:
alvr/launcher/src/main.rs#L6
warning: unused import: `Permissions`
--> alvr/launcher/src/main.rs:6:22
|
6 | fs::{self, File, Permissions},
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`:
alvr\server\src\connection.rs#L343
warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
--> alvr\server\src\connection.rs:343:21
|
343 | let handshake = proto_socket.recv(HANDSHAKE_ACTION_TIMEOUT).or_else(|err| {
| _____________________^
344 | | server_data_lock.update_client_list(
345 | | client_hostname.clone(),
346 | | ClientListAction::SetConnectionState(ConnectionState::Disconnected),
... |
349 | | Err(err)
350 | | })?;
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
help: try
|
343 ~ let handshake = proto_socket.recv(HANDSHAKE_ACTION_TIMEOUT).map_err(|err| {
344 | server_data_lock.update_client_list(
...
348 |
349 ~ err
|
|
|
accessing first element with `from_openvr_paths(paths_json).get(0)`:
alvr\server_io\src\openvrpaths.rs#L74
warning: accessing first element with `from_openvr_paths(paths_json).get(0)`
--> alvr\server_io\src\openvrpaths.rs:74:5
|
74 | from_openvr_paths(paths_json).get(0).cloned().to_any()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_openvr_paths(paths_json).first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
|
variable does not need to be mutable:
alvr\launcher\src\main.rs#L761
warning: variable does not need to be mutable
--> alvr\launcher\src\main.rs:761:9
|
761 | let mut installation_dir = data_dir().extended(VERSIONS_SUBDIR).extended(&release.tag);
| ----^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused import: `Permissions`:
alvr\launcher\src\main.rs#L6
warning: unused import: `Permissions`
--> alvr\launcher\src\main.rs:6:22
|
6 | fs::{self, File, Permissions},
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`:
alvr/server/src/connection.rs#L343
warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
--> alvr/server/src/connection.rs:343:21
|
343 | let handshake = proto_socket.recv(HANDSHAKE_ACTION_TIMEOUT).or_else(|err| {
| _____________________^
344 | | server_data_lock.update_client_list(
345 | | client_hostname.clone(),
346 | | ClientListAction::SetConnectionState(ConnectionState::Disconnected),
... |
349 | | Err(err)
350 | | })?;
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
help: try
|
343 ~ let handshake = proto_socket.recv(HANDSHAKE_ACTION_TIMEOUT).map_err(|err| {
344 | server_data_lock.update_client_list(
...
348 |
349 ~ err
|
|
|
unused import: `self::VkLoaderFeastureFlagBits as VkLoaderFlagBits`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L71964
warning: unused import: `self::VkLoaderFeastureFlagBits as VkLoaderFlagBits`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:71964:9
|
71964 | pub use self::VkLoaderFeastureFlagBits as VkLoaderFlagBits;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L64273
warning: unused import: `self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:64273:9
|
64273 | pub use self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L59508
warning: unused import: `self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:59508:9
|
59508 | pub use self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L56634
warning: unused import: `self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:56634:9
|
56634 | pub use self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L55649
warning: unused import: `self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:55649:9
|
55649 | pub use self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L53622
warning: unused import: `self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:53622:9
|
53622 | pub use self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L53605
warning: unused import: `self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:53605:9
|
53605 | pub use self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L53584
warning: unused import: `self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:53584:9
|
53584 | pub use self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L53567
warning: unused import: `self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:53567:9
|
53567 | pub use self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkGeometryTypeKHR as VkGeometryTypeNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L53537
warning: unused import: `self::VkGeometryTypeKHR as VkGeometryTypeNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:53537:9
|
53537 | pub use self::VkGeometryTypeKHR as VkGeometryTypeNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L53529
warning: unused import: `self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:53529:9
|
53529 | pub use self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L52892
warning: unused import: `self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:52892:9
|
52892 | pub use self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSamplerReductionMode as VkSamplerReductionModeEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L50733
warning: unused import: `self::VkSamplerReductionMode as VkSamplerReductionModeEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:50733:9
|
50733 | pub use self::VkSamplerReductionMode as VkSamplerReductionModeEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSubmitFlagBits as VkSubmitFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L44495
warning: unused import: `self::VkSubmitFlagBits as VkSubmitFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:44495:9
|
44495 | pub use self::VkSubmitFlagBits as VkSubmitFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L42667
warning: unused import: `self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:42667:9
|
42667 | pub use self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSemaphoreType as VkSemaphoreTypeKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L42666
warning: unused import: `self::VkSemaphoreType as VkSemaphoreTypeKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:42666:9
|
42666 | pub use self::VkSemaphoreType as VkSemaphoreTypeKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L42661
warning: unused import: `self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:42661:9
|
42661 | pub use self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L42659
warning: unused import: `self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:42659:9
|
42659 | pub use self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkDriverId as VkDriverIdKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L42656
warning: unused import: `self::VkDriverId as VkDriverIdKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:42656:9
|
42656 | pub use self::VkDriverId as VkDriverIdKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L42212
warning: unused import: `self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:42212:9
|
42212 | pub use self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L42211
warning: unused import: `self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:42211:9
|
42211 | pub use self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkChromaLocation as VkChromaLocationKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L42210
warning: unused import: `self::VkChromaLocation as VkChromaLocationKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:42210:9
|
42210 | pub use self::VkChromaLocation as VkChromaLocationKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L41553
warning: unused import: `self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:41553:9
|
41553 | pub use self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPointClippingBehavior as VkPointClippingBehaviorKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L41552
warning: unused import: `self::VkPointClippingBehavior as VkPointClippingBehaviorKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:41552:9
|
41552 | pub use self::VkPointClippingBehavior as VkPointClippingBehaviorKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkFenceImportFlagBits as VkFenceImportFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L40581
warning: unused import: `self::VkFenceImportFlagBits as VkFenceImportFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:40581:9
|
40581 | pub use self::VkFenceImportFlagBits as VkFenceImportFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalFenceFeatureFlagBits as VkExternalFenceFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L40563
warning: unused import: `self::VkExternalFenceFeatureFlagBits as VkExternalFenceFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:40563:9
|
40563 | pub use self::VkExternalFenceFeatureFlagBits as VkExternalFenceFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalFenceHandleTypeFlagBits as VkExternalFenceHandleTypeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L40561
warning: unused import: `self::VkExternalFenceHandleTypeFlagBits as VkExternalFenceHandleTypeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:40561:9
|
40561 | pub use self::VkExternalFenceHandleTypeFlagBits as VkExternalFenceHandleTypeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkDescriptorUpdateTemplateType as VkDescriptorUpdateTemplateTypeKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L40369
warning: unused import: `self::VkDescriptorUpdateTemplateType as VkDescriptorUpdateTemplateTypeKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:40369:9
|
40369 | pub use self::VkDescriptorUpdateTemplateType as VkDescriptorUpdateTemplateTypeKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSemaphoreImportFlagBits as VkSemaphoreImportFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L39889
warning: unused import: `self::VkSemaphoreImportFlagBits as VkSemaphoreImportFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:39889:9
|
39889 | pub use self::VkSemaphoreImportFlagBits as VkSemaphoreImportFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalSemaphoreFeatureFlagBits as VkExternalSemaphoreFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L39871
warning: unused import: `self::VkExternalSemaphoreFeatureFlagBits as VkExternalSemaphoreFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:39871:9
|
39871 | pub use self::VkExternalSemaphoreFeatureFlagBits as VkExternalSemaphoreFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalSemaphoreHandleTypeFlagBits as VkExternalSemaphoreHandleTypeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L39869
warning: unused import: `self::VkExternalSemaphoreHandleTypeFlagBits as VkExternalSemaphoreHandleTypeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:39869:9
|
39869 | pub use self::VkExternalSemaphoreHandleTypeFlagBits as VkExternalSemaphoreHandleTypeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalMemoryFeatureFlagBits as VkExternalMemoryFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L39607
warning: unused import: `self::VkExternalMemoryFeatureFlagBits as VkExternalMemoryFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:39607:9
|
39607 | pub use self::VkExternalMemoryFeatureFlagBits as VkExternalMemoryFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalMemoryHandleTypeFlagBits as VkExternalMemoryHandleTypeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L39605
warning: unused import: `self::VkExternalMemoryHandleTypeFlagBits as VkExternalMemoryHandleTypeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:39605:9
|
39605 | pub use self::VkExternalMemoryHandleTypeFlagBits as VkExternalMemoryHandleTypeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkMemoryAllocateFlagBits as VkMemoryAllocateFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L39520
warning: unused import: `self::VkMemoryAllocateFlagBits as VkMemoryAllocateFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:39520:9
|
39520 | pub use self::VkMemoryAllocateFlagBits as VkMemoryAllocateFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPeerMemoryFeatureFlagBits as VkPeerMemoryFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L39518
warning: unused import: `self::VkPeerMemoryFeatureFlagBits as VkPeerMemoryFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:39518:9
|
39518 | pub use self::VkPeerMemoryFeatureFlagBits as VkPeerMemoryFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkRenderingFlagBits as VkRenderingFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs#L39055
warning: unused import: `self::VkRenderingFlagBits as VkRenderingFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-8431a48fddc4b31d/out/layer_bindings.rs:39055:9
|
39055 | pub use self::VkRenderingFlagBits as VkRenderingFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unnecessary use of `to_string`:
alvr/dashboard/src/dashboard/components/setup_wizard.rs#L178
warning: unnecessary use of `to_string`
--> alvr/dashboard/src/dashboard/components/setup_wizard.rs:178:45
|
178 | ... &audio_script_path.to_string_lossy().to_string(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `audio_script_path.to_string_lossy().as_ref()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
|
|
unnecessary use of `to_string`:
alvr/dashboard/src/dashboard/components/setup_wizard.rs#L174
warning: unnecessary use of `to_string`
--> alvr/dashboard/src/dashboard/components/setup_wizard.rs:174:45
|
174 | ... &audio_script_path.to_string_lossy().to_string(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `audio_script_path.to_string_lossy().as_ref()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
= note: `#[warn(clippy::unnecessary_to_owned)]` on by default
|
|
accessing first element with `from_openvr_paths(paths_json).get(0)`:
alvr/server_io/src/openvrpaths.rs#L74
warning: accessing first element with `from_openvr_paths(paths_json).get(0)`
--> alvr/server_io/src/openvrpaths.rs:74:5
|
74 | from_openvr_paths(paths_json).get(0).cloned().to_any()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_openvr_paths(paths_json).first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|