-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM MacOS support for Python Bindings #351
Conversation
@alphaville AFAICT that MacOS job will never run - as part of this PR will I update the CI definition to use Looks like macos-11 runner got deactivated in June. I'm surprised it doesn't give a proper error, seems to match the behaviour described here when Ubuntu got updated a while back. |
@Creelman yes, I realised and created an issue (see #352). Can you please change it to |
Should be ready to try a build again |
Had to make a few more changes to support the new MacOS runner
IIUC the documentation failure is because I'm testing in a fork, and should succeed on a rerun of the CI pipeline here. Apologies for adding quite a few commits for a relatively small change - I couldn't replicate the issue locally. |
@Creelman many thanks for all the good work! I'll merge this now and I'll create a new version afterwards. |
Main Changes
Updates the Python direct interface
.cargo/config
template file to work with ARM-based Macs.Fix based on PyO3 docs here
Associated Issues
TODOs
CHANGELOG
(s)CHANGELOG
,Cargo.toml
andVERSION
)Other
Tested on M2 Max Macbook Pro