Use modules for sensitive WAF config #1666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be a use case for the private module registry? https://developer.hashicorp.com/terraform/cloud-docs/registry/publish-modules That might be a bit complicated though |
theseanything
force-pushed
the
use-modules-for-sensitive-resources
branch
13 times, most recently
from
fcb4621 to
c488a09
Compare
theseanything
force-pushed
the
use-modules-for-sensitive-resources
branch
from
c488a09 to
8646b36
Compare
theseanything
force-pushed
the
use-modules-for-sensitive-resources
branch
from
48ce053 to
a3ad192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a private module to create privates WAF resources and set private variables. These modules are defined in https://github.com/alphagov/terraform-govuk-infrastructure-sensitive (annoying had to use this name convention for TFC) .
As part of the tfc-configuration workspace, a sensitive variable set for WAFs is created for each environments.
Then for each of the govuk-publishing-infrastructure projects, they are configured to use the respective variable-set and to create the private WAF resource.
(tfc-configuration project needs to be run twice; once to create the variable set, then to assign it to the relevant projects. Hence will error on review of this PR.)