EmbedCard improvements #4503
Draft
EmbedCard improvements #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `IntersectionObserver` is not supported by the browser (it's not present on `window`) then don't run the `IntersectionObserver` code in `application.mjs` to enable lazy-load of the Youtube embeds. Instead, the fallback (linking to the Youtube video) will be used.
Remove confusing `.app-campaign-cookie-banner .govuk-grid-column-two-thirds` selector and replace with `div`.
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To address comments left on the previous PR.
Why
So that the EmbedCard component can be used to enhance the site.