Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sass warnings #3917

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix Sass warnings #3917

merged 1 commit into from
Dec 19, 2024

Conversation

andysellick
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Fix Sass compilation warnings in the console. Declarations starting with e.g. @include must follow other declarations, not precede them.

Why

The linting rules for this changed a while back when we upgraded to the latest version of the sass compiler.

Visual changes

None.

- declarations starting with e.g. `@include` must follow other declarations, not precede them
@govuk-ci govuk-ci temporarily deployed to collections-pr-3917 December 19, 2024 09:56 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, less noisy now when compiling the CSS 👍

@andysellick andysellick merged commit 0936c40 into main Dec 19, 2024
15 checks passed
@andysellick andysellick deleted the fix-more-sass-warnings branch December 19, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants