Update GraphQL approach for world index #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
force-pushed
the
update-world-index-shape
branch
from
5ba7de7 to
648c052
Compare
Given we're still in the learning stage with the GraphQL project, we've decided to minimise the changes needed on frontend apps by retaining the current heavily nested data structure. This updates Collections to work with that format (the changes to Publishing API are also in progress). This means that the code for the world index page in collections will be less divergent between paths for GraphQL and REST data sources. This commit undoes some of the divergence we initially introduced We plan to revisit simplifying the data structure later (into a less nested form)
yndajas
force-pushed
the
update-world-index-shape
branch
from
648c052 to
dd98c9f
Compare
brucebolt
reviewed
Dec 16, 2024
Comment on lines
+12
to
+13
| .dig("data", "edition") | ||
| .deep_transform_keys(&:underscore) |
There was a problem hiding this comment.
I'm hoping to remove the need for this in a future version of gds-api-adapters.
brucebolt
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
Given we're still in the learning stage with the GraphQL project, we've decided to minimise the changes needed on frontend apps by retaining the current heavily nested data structure. This updates Collections to work with that format (the changes to Publishing API are also in progress). This means that the code for the world index page in collections will be less divergent between paths for GraphQL and REST data sources. This commit undoes some of the divergence we initially introduced
We plan to revisit simplifying the data structure later (into a less nested form)
Publishing API PR
Follow these steps if you are doing a Rails upgrade.