Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Popular tasks' heading to 'Most viewed' #3887

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Change 'Popular tasks' heading to 'Most viewed' #3887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49b0d07
Change 'Popular tasks' heading to 'Most viewed'
catalinailie Dec 3, 2024
1e59b60
Update ga4 tracking section
catalinailie Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/browse_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def with_tracking_data(popular_content)
index_link: index,
index_total: count,
text: link[:title],
section: "Popular tasks",
section: "Most viewed",
},
},
}
Expand Down
2 changes: 1 addition & 1 deletion config/locales/en/browse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ en:
- title: Check your State Pension forecast
url: /check-state-pension
all_categories: All categories
popular_tasks: Popular tasks
popular_tasks: Most viewed
topics: Topics
description: Find the government services, forms and accounts you need to use
title: Services and information
6 changes: 3 additions & 3 deletions spec/features/mainstream_browsing_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

visit content_item["base_path"]
expect(page).to have_css(".browse__action-links")
expect(page).to have_content("Popular tasks")
expect(page).to have_content("Most viewed")
end
end

Expand All @@ -54,7 +54,7 @@

visit content_item["base_path"]
expect(page).not_to have_css(".browse__action-links")
expect(page).not_to have_content("Popular tasks")
expect(page).not_to have_content("Most viewed")
end

it "does not render on level two browse pages" do
Expand All @@ -64,7 +64,7 @@

visit content_item["base_path"]
expect(page).not_to have_css(".browse__action-links")
expect(page).not_to have_content("Popular tasks")
expect(page).not_to have_content("Most viewed")
end

it "renders the GOV.UK Chat promo" do
Expand Down
6 changes: 3 additions & 3 deletions spec/helpers/browse_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
index_link: 1,
index_total: 3,
text: "Policy on World Locations",
section: "Popular tasks",
section: "Most viewed",
},
},
},
Expand All @@ -45,7 +45,7 @@
index_link: 2,
index_total: 3,
text: "PM attends summit on world location news pages",
section: "Popular tasks",
section: "Most viewed",
},
},
},
Expand All @@ -61,7 +61,7 @@
index_link: 3,
index_total: 3,
text: "Anything",
section: "Popular tasks",
section: "Most viewed",
},
},
},
Expand Down
Loading