Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA4 tracking to organisation pages #3539

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Add GA4 tracking to organisation pages #3539

merged 1 commit into from
Feb 22, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Feb 13, 2024

What

Why

Testing

Image cards

  • you can see the image cards working on this page under the sections "Featured", "Meet the prime minister", "History", etc. You can also see them on the "Related people" section of this page.

Topic list / document list

See all latest documents / Get emails link

Email contact links

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 13, 2024 11:46 Inactive
@AshGDS AshGDS force-pushed the ga4-organisation-pages branch from 0c7083d to a410dc5 Compare February 13, 2024 11:55
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 13, 2024 11:55 Inactive
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 14, 2024 14:20 Inactive
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 14, 2024 15:33 Inactive
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 15, 2024 14:27 Inactive
@AshGDS AshGDS force-pushed the ga4-organisation-pages branch from ef2a596 to 6a3919d Compare February 15, 2024 14:51
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 15, 2024 14:52 Inactive
@AshGDS AshGDS force-pushed the ga4-organisation-pages branch from 6a3919d to 12d305a Compare February 15, 2024 15:11
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 15, 2024 15:11 Inactive
@AshGDS AshGDS force-pushed the ga4-organisation-pages branch from 12d305a to f6714a6 Compare February 16, 2024 09:58
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 16, 2024 09:59 Inactive
"section": title
}.to_json
%>
<section class="brand--<%= brand %> brand__border-color organisation__brand-border-top organisation__margin-bottom" data-people-id="<%= title.downcase.split(' ').join('-')%>">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added data-people-id for testing purposes, as these elements had no distinguishable CSS selector.

@AshGDS AshGDS requested a review from andysellick February 16, 2024 10:08
@AshGDS AshGDS marked this pull request as ready for review February 16, 2024 10:08
@AshGDS AshGDS marked this pull request as draft February 20, 2024 13:49
@AshGDS AshGDS force-pushed the ga4-organisation-pages branch from f6714a6 to abfc94c Compare February 20, 2024 14:32
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 20, 2024 14:32 Inactive
@AshGDS AshGDS marked this pull request as ready for review February 20, 2024 14:39
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, couple of probably very minor comments. If possible can you merge some of the commits that add tests with the code that they relate to? Thanks

app/views/components/_topic_list.html.erb Show resolved Hide resolved
app/views/organisations/_org_contacts.html.erb Outdated Show resolved Hide resolved
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 21, 2024 15:23 Inactive
@AshGDS AshGDS force-pushed the ga4-organisation-pages branch from e272147 to 06b92ed Compare February 21, 2024 15:42
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 21, 2024 15:42 Inactive
@AshGDS
Copy link
Contributor Author

AshGDS commented Feb 21, 2024

Thanks @andysellick - should be ready for review again, and i've squashed down the commits.

@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 21, 2024 15:55 Inactive
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 21, 2024 16:16 Inactive
@AshGDS AshGDS force-pushed the ga4-organisation-pages branch from a78a812 to ed9d20b Compare February 21, 2024 16:20
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 21, 2024 16:21 Inactive
@AshGDS
Copy link
Contributor Author

AshGDS commented Feb 21, 2024

@andysellick OK now it should be ready - had to add another commit as I realised I've been using lang: :en instead of locale: :en (I also did this by mistake in two other recent tracking PRs, so will fix those when I can)

Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 remember to squash your extra commits 👍

Adds or updates tracking to:
- image cards
- document list/topic list components
- 'see all latest documents' and 'Get emails' link
- stops redacting email links in contact sections
- adds 'section' to share links
@AshGDS AshGDS force-pushed the ga4-organisation-pages branch from ed9d20b to 04cad4e Compare February 22, 2024 14:08
@govuk-ci govuk-ci temporarily deployed to collections-pr-3539 February 22, 2024 14:08 Inactive
@AshGDS AshGDS merged commit e4f2cf0 into main Feb 22, 2024
15 checks passed
@AshGDS AshGDS deleted the ga4-organisation-pages branch February 22, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants