-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA4 tracking to organisation pages #3539
Conversation
0c7083d
to
a410dc5
Compare
ef2a596
to
6a3919d
Compare
6a3919d
to
12d305a
Compare
12d305a
to
f6714a6
Compare
"section": title | ||
}.to_json | ||
%> | ||
<section class="brand--<%= brand %> brand__border-color organisation__brand-border-top organisation__margin-bottom" data-people-id="<%= title.downcase.split(' ').join('-')%>"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added data-people-id
for testing purposes, as these elements had no distinguishable CSS selector.
f6714a6
to
abfc94c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, couple of probably very minor comments. If possible can you merge some of the commits that add tests with the code that they relate to? Thanks
e272147
to
06b92ed
Compare
Thanks @andysellick - should be ready for review again, and i've squashed down the commits. |
a78a812
to
ed9d20b
Compare
@andysellick OK now it should be ready - had to add another commit as I realised I've been using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 remember to squash your extra commits 👍
Adds or updates tracking to: - image cards - document list/topic list components - 'see all latest documents' and 'Get emails' link - stops redacting email links in contact sections - adds 'section' to share links
ed9d20b
to
04cad4e
Compare
What
Get emails
andSee all latest documents
linkssection
to share links, relevant PR Expand GA4 share link tracking to allow for extra values govuk_publishing_components#3872Why
Testing
Image cards
Topic list / document list
See all latest documents / Get emails link
Email contact links
Follow these steps if you are doing a Rails upgrade.