Fix empty link in phase banner on worldwide taxon pages #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
approved these changes
Feb 13, 2024
georges1996
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the survey link in the phase banner on worldwide taxon pages. The link doesn't currently render the link text and therefore the link itself is not being rendered. This was picked up in a recent accessibility audit of GOV.UK pages.
The syntax was originally included here and appears to be an oversight rather than there being some other intended purpose for it.
Preview of the relevant page
Trello ticket
--
Follow these steps if you are doing a Rails upgrade.