Upgrade app configuration to Rails 7.1 #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
changed the title
unoduetre
changed the title
unoduetre
commented
Jan 12, 2024
| @@ -5,7 +5,7 @@ require "fileutils" | |||
| APP_ROOT = File.expand_path("..", __dir__) | |||
|
|
|||
| def system!(*args) | |||
| system(*args) || abort("\n== Command #{args} failed ==") | |||
| system(*args, exception: true) | |||
There was a problem hiding this comment.
Change made by Rails
| @@ -1,4 +1,4 @@ | |||
| ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__) | |||
|
|
|||
| require "bundler/setup" # Set up gems listed in the Gemfile. | |||
| require "bootsnap/setup" | |||
| require "bootsnap/setup" # Speed up boot time by caching expensive operations. | |||
There was a problem hiding this comment.
This comment is from Rails.
| @@ -6,7 +6,7 @@ | |||
| # In the development environment your application's code is reloaded any time | |||
| # it changes. This slows down response time but is perfect for development | |||
| # since you don't have to restart the web server when you make code changes. | |||
| config.cache_classes = false | |||
| config.enable_reloading = true | |||
There was a problem hiding this comment.
Rails changed the name of this option and reversed it, so enable_reloading=!cache_classes
| @@ -47,6 +47,9 @@ | |||
| # Tell Active Support which deprecation messages to disallow. | |||
| config.active_support.disallowed_deprecation_warnings = [] | |||
|
|
|||
| # Highlight code that enqueued background job in logs. | |||
| config.active_job.verbose_enqueue_logs = true | |||
| @@ -56,6 +59,9 @@ | |||
| # Annotate rendered view with file names. | |||
| # config.action_view.annotate_rendered_view_with_filenames = true | |||
|
|
|||
| # Raise error when a before_action's only/except options reference missing actions | |||
| config.action_controller.raise_on_missing_callback_actions = true | |||
| logger.formatter = config.log_formatter | ||
| config.logger = ActiveSupport::TaggedLogging.new(logger) | ||
| end | ||
| # Enable DNS rebinding protection and other `Host` header attacks. |
There was a problem hiding this comment.
Added by Rails, commented by default.
| @@ -8,8 +8,8 @@ | |||
| Rails.application.configure do | |||
| # Settings specified here will take precedence over those in config/application.rb. | |||
|
|
|||
| # Turn false under Spring and add config.action_view.cache_template_loading = true. | |||
| config.cache_classes = true | |||
| # While tests run files are not watched, reloading is not necessary. | |||
| @@ -27,8 +27,8 @@ | |||
| config.action_controller.perform_caching = false | |||
| config.cache_store = :null_store | |||
|
|
|||
| # Raise exceptions instead of rendering exception templates. | |||
| config.action_dispatch.show_exceptions = false | |||
| # Render exception templates for rescuable exceptions and raise for other exceptions. | |||
There was a problem hiding this comment.
New Rails default for the test environment.
| # f.usb :none | ||
| # f.fullscreen :self | ||
| # f.payment :self, "https://secure.example.com" | ||
| # information see: https://developers.google.com/web/updates/2018/06/feature-policy |
| @@ -54,4 +54,7 @@ | |||
|
|
|||
| # Annotate rendered view with file names. | |||
| # config.action_view.annotate_rendered_view_with_filenames = true | |||
|
|
|||
| # Raise error when a before_action's only/except options reference missing actions | |||
Autoloaded paths are no longer in $LOAD_PATH. The file services.rb is in app/lib which is autoloaded.
unoduetre
changed the title
Tetrino
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
We need to upgrade our apps to the latest version of Rails.
How
Follow these steps: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#moving-between-versions
Trello ticket