Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add user research banner" #3424

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Revert "Add user research banner" #3424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions app/helpers/recruitment_banner_helper.rb
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions app/models/mainstream_browse_page.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
class MainstreamBrowsePage
include RecruitmentBannerHelper

attr_reader :content_item

delegate(
Expand Down
2 changes: 0 additions & 2 deletions app/models/topic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
class Topic
include RecruitmentBannerHelper

attr_reader :content_item

delegate(
Expand Down
13 changes: 1 addition & 12 deletions app/views/browse/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
} %>
<% end %>

<%= render "shared/browse_header", { margin_bottom: page.slug == "benefits" || page.recruitment_survey_url ? 7 : 9 } do %>
<%= render "shared/browse_header", { margin_bottom: page.slug == "benefits" ? 7 : 9 } do %>
<h1 class="browse__heading govuk-heading-xl">
<%= page.title %>
</h1>
Expand All @@ -31,17 +31,6 @@
} %>
<% end %>

<% if page.recruitment_survey_url %>
<div class="govuk-width-container">
<%= render "govuk_publishing_components/components/intervention", {
suggestion_text: "Help improve a new GOV.UK tool",
suggestion_link_text: "Sign up to take part in user research",
suggestion_link_url: page.recruitment_survey_url,
new_tab: true,
} %>
</div>
<% end %>

<% if page.slug == "benefits" %>
<div class="govuk-width-container">
<div class="govuk-grid-row">
Expand Down
15 changes: 2 additions & 13 deletions app/views/second_level_browse_page/show_curated.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
<%= render "shared/browse_breadcrumbs" %>
<% end %>

<% margin_bottom = page.recruitment_survey_url ? 7 : 8 %>
<%= render "shared/browse_header", { two_thirds: true, margin_bottom: margin_bottom } do %>
<%= render "shared/browse_header", { two_thirds: true, margin_bottom: 8 } do %>

<%= render "govuk_publishing_components/components/heading", {
font_size: "xl",
heading_level: 1,
Expand All @@ -33,17 +33,6 @@
} %>
<% end %>

<% if page.recruitment_survey_url %>
<div class="govuk-width-container">
<%= render "govuk_publishing_components/components/intervention", {
suggestion_text: "Help improve a new GOV.UK tool",
suggestion_link_text: "Sign up to take part in user research",
suggestion_link_url: page.recruitment_survey_url,
new_tab: true,
} %>
</div>
<% end %>

<div class="govuk-width-container">
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds" data-module="ga4-link-tracker">
Expand Down
11 changes: 0 additions & 11 deletions app/views/subtopics/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,6 @@
<%= render "govuk_publishing_components/components/title", title_params %>
<% end %>

<% if subtopic.recruitment_survey_url %>
<div class="govuk-!-static-margin-top-4">
<%= render "govuk_publishing_components/components/intervention", {
suggestion_text: "Help improve a new GOV.UK tool",
suggestion_link_text: "Sign up to take part in user research",
suggestion_link_url: subtopic.recruitment_survey_url,
new_tab: true,
} %>
</div>
<% end %>

<%= render(
layout: "subtopic",
locals: {
Expand Down
29 changes: 0 additions & 29 deletions spec/features/research_panel_banner_spec.rb
View file
Open in desktop

This file was deleted.