Flatten GA4 attributes #3417
Merged
Flatten GA4 attributes #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
requested changes
Oct 27, 2023
- we no longer need to nest GA4 attributes attached to elements, notably the index attributes - these attributes when collected by trackers are automatically nested based on the structure of the GA4 schema, held in the gem - flattening them here saves code and complexity
andysellick
force-pushed
the
flatten-ga4-attributes
branch
from
e90621a to
96ab6d8
Compare
AshGDS
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
Visual changes
None.
Trello card: https://trello.com/c/IseA05Fd/644-remove-nesting-of-ga4-attributes