From 49b0d07e3419590f89940379640a0965de4fab3a Mon Sep 17 00:00:00 2001 From: Catalina Ilie Date: Tue, 3 Dec 2024 10:45:34 +0000 Subject: [PATCH 1/2] =?UTF-8?q?Change=20'Popular=20tasks'=20heading=20to?= =?UTF-8?q?=20'Most=20viewed'=20We=E2=80=99re=20changing=20'Popular=20task?= =?UTF-8?q?s'=20heading=20to=20'Most=20viewed'=20on=20mainstream=20browse?= =?UTF-8?q?=20level=201=20pages.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The change makes the heading clearer and more descriptive by telling users what the links are based on and makes the language more neutral. --- config/locales/en/browse.yml | 2 +- spec/features/mainstream_browsing_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/locales/en/browse.yml b/config/locales/en/browse.yml index 72a56a40f..c841db3e3 100644 --- a/config/locales/en/browse.yml +++ b/config/locales/en/browse.yml @@ -115,7 +115,7 @@ en: - title: Check your State Pension forecast url: /check-state-pension all_categories: All categories - popular_tasks: Popular tasks + popular_tasks: Most viewed topics: Topics description: Find the government services, forms and accounts you need to use title: Services and information diff --git a/spec/features/mainstream_browsing_spec.rb b/spec/features/mainstream_browsing_spec.rb index 8faf8fcb8..071c80857 100644 --- a/spec/features/mainstream_browsing_spec.rb +++ b/spec/features/mainstream_browsing_spec.rb @@ -44,7 +44,7 @@ visit content_item["base_path"] expect(page).to have_css(".browse__action-links") - expect(page).to have_content("Popular tasks") + expect(page).to have_content("Most viewed") end end @@ -54,7 +54,7 @@ visit content_item["base_path"] expect(page).not_to have_css(".browse__action-links") - expect(page).not_to have_content("Popular tasks") + expect(page).not_to have_content("Most viewed") end it "does not render on level two browse pages" do @@ -64,7 +64,7 @@ visit content_item["base_path"] expect(page).not_to have_css(".browse__action-links") - expect(page).not_to have_content("Popular tasks") + expect(page).not_to have_content("Most viewed") end it "renders the GOV.UK Chat promo" do From 1e59b6040f5872a43446cb6f20f174bf0dcc002a Mon Sep 17 00:00:00 2001 From: Catalina Ilie Date: Tue, 3 Dec 2024 15:13:33 +0000 Subject: [PATCH 2/2] Update ga4 tracking section --- app/helpers/browse_helper.rb | 2 +- spec/helpers/browse_helper_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/helpers/browse_helper.rb b/app/helpers/browse_helper.rb index 1d3fa2ec2..cf55be7b3 100644 --- a/app/helpers/browse_helper.rb +++ b/app/helpers/browse_helper.rb @@ -14,7 +14,7 @@ def with_tracking_data(popular_content) index_link: index, index_total: count, text: link[:title], - section: "Popular tasks", + section: "Most viewed", }, }, } diff --git a/spec/helpers/browse_helper_spec.rb b/spec/helpers/browse_helper_spec.rb index 08b1f39fd..1a5758113 100644 --- a/spec/helpers/browse_helper_spec.rb +++ b/spec/helpers/browse_helper_spec.rb @@ -29,7 +29,7 @@ index_link: 1, index_total: 3, text: "Policy on World Locations", - section: "Popular tasks", + section: "Most viewed", }, }, }, @@ -45,7 +45,7 @@ index_link: 2, index_total: 3, text: "PM attends summit on world location news pages", - section: "Popular tasks", + section: "Most viewed", }, }, }, @@ -61,7 +61,7 @@ index_link: 3, index_total: 3, text: "Anything", - section: "Popular tasks", + section: "Most viewed", }, }, },