Improve CWL parsing performance #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
improve-cwl-translation
branch
from
f0c9a77 to
ccd0623
Compare
LanderOtto
approved these changes
Feb 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 71.44% 71.40% -0.05%
==========================================
Files 88 88
Lines 11345 11349 +4
Branches 1981 1983 +2
==========================================
- Hits 8106 8104 -2
- Misses 2785 2788 +3
- Partials 454 457 +3 ☔ View full report in Codecov by Sentry. |
GlassOfWhiskey
force-pushed
the
improve-cwl-translation
branch
3 times, most recently
from
bc54e10 to
7d9fe03
Compare
This commit improves CWL parsing by removing useless `deepcopy` of the `context` object in the `CWLTranslator` class. The `context` dictionary is now simply copied through the `copy.copy` method.
GlassOfWhiskey
force-pushed
the
improve-cwl-translation
branch
from
7d9fe03 to
4cc3154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves CWL parsing by removing useless
deepcopyof thecontextobject in theCWLTranslatorclass. Thecontextdictionary is now simply copied through thecopy.copymethod.