Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add multi-leg options #552

Merged
merged 19 commits into from
Jan 20, 2025
Merged

feat: Add multi-leg options #552

merged 19 commits into from
Jan 20, 2025
+1,293 −341

Conversation

aarjaneiro
Copy link
Member

Closes #551.

@aarjaneiro
create enum for mleg + adds request
8f65a15
@aarjaneiro
Merge branch 'master' into feat-mleg-orders
7824231
@aarjaneiro
feat: ipynb fully works with fixes
aa7a965 
feat: examples
feat: update model for mleg
feat: add missing qty test
feat: trailing stop limit validator separated
feat: emit warning with info upon validation test failing
feat: limit + mleg validation
feat: adds validation + tests for symbol repetition
feat: adds validation + tests
feat: add legs as parameter to order-type requests
@aarjaneiro
fix: docgen
ee6f1bc 
refactor: cleanup

fix: to_request_fields empty detection

refactor: typing

refactor: prettiness
@aarjaneiro aarjaneiro requested a review from hiohiohio as a code owner January 17, 2025 18:33
hiohiohio
hiohiohio reviewed Jan 18, 2025
View reviewed changes
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! The notebook is fantastic! Left small comments.

alpaca/trading/models.py Outdated Show resolved Hide resolved
alpaca/trading/models.py Outdated Show resolved Hide resolved
alpaca/trading/models.py Outdated Show resolved Hide resolved
alpaca/trading/requests.py Show resolved Hide resolved
alpaca/trading/requests.py Outdated Show resolved Hide resolved
alpaca/trading/enums.py Outdated Show resolved Hide resolved
alpaca/trading/requests.py Outdated Show resolved Hide resolved
alpaca/trading/models.py Show resolved Hide resolved
aarjaneiro and others added 8 commits January 18, 2025 11:04
@aarjaneiro @hiohiohio
Update alpaca/trading/models.py
41749ef 
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
@aarjaneiro @hiohiohio
Update alpaca/trading/models.py
7b2354b 
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
@aarjaneiro @hiohiohio
Update alpaca/trading/models.py
ca1f2ac 
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
@aarjaneiro @hiohiohio
Update alpaca/trading/requests.py
fdf4629 
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
@aarjaneiro @hiohiohio
Update alpaca/trading/enums.py
4d104a6 
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
@aarjaneiro @hiohiohio
Update alpaca/trading/models.py
86b69ec 
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
@aarjaneiro
feat: adds validation test for one of side or position intent in Opti…
2467e7d 
…onLegRequest
@aarjaneiro
Merge remote-tracking branch 'origin/feat-mleg-option-orders' into fe…
6894195 
…at-mleg-orders
@aarjaneiro aarjaneiro requested a review from hiohiohio January 18, 2025 16:19
@aarjaneiro
reformat
e77f87b 
feat: typing for `leg` parameters
@aarjaneiro aarjaneiro force-pushed the feat-mleg-option-orders branch from cf5f311 to e77f87b Compare January 18, 2025 16:20
@OlegRa OlegRa mentioned this pull request Jan 19, 2025
Closed
hiohiohio
hiohiohio approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Left small comments.

alpaca/trading/models.py Show resolved Hide resolved
alpaca/trading/models.py Outdated Show resolved Hide resolved
examples/options-trading-mleg.ipynb Outdated Show resolved Hide resolved
@aarjaneiro
fixes re: @hiohiohio
27ae701 
fix: prefer !python3 -m pip install alpaca-py

refactor: ratio_qty docstring added

fix: implement suggestion re: validating api returns
hiohiohio
hiohiohio approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

matebudai
matebudai approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@matebudai matebudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aarjaneiro aarjaneiro merged commit e2466ba into master Jan 20, 2025
12 checks passed
@aarjaneiro aarjaneiro deleted the feat-mleg-option-orders branch January 20, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matebudai matebudai matebudai approved these changes

@hiohiohio hiohiohio hiohiohio approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@AlexandrosKyriakakis AlexandrosKyriakakis Awaiting requested review from AlexandrosKyriakakis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add multi-leg options
3 participants
@aarjaneiro @hiohiohio @matebudai