Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support option historical data #406

Merged
merged 6 commits into from
Feb 6, 2024
Merged

feat: Support option historical data #406

merged 6 commits into from
Feb 6, 2024

Conversation

hiohiohio
Copy link
Contributor

Context:

  • market data for options are introduced

Changes:

  • add OptionHistoricalDataClient

@OlegRa OlegRa mentioned this pull request Jan 24, 2024
Closed
2 tasks
@hiohiohio hiohiohio requested a review from gnvk February 5, 2024 07:17
gnvk
gnvk approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@gnvk gnvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiohiohio hiohiohio merged commit 51ef66a into master Feb 6, 2024
12 checks passed
@hiohiohio hiohiohio deleted the support-option-historical-data branch February 6, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnvk gnvk gnvk approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@AlexandrosKyriakakis AlexandrosKyriakakis Awaiting requested review from AlexandrosKyriakakis

@matebudai matebudai Awaiting requested review from matebudai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiohiohio @gnvk