don't wait for proxy process to terminate (#51)

aloneguid · Sep 25, 2023 · f078c9a · f078c9a
1 parent 41c5559
commit f078c9a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1,7 +1,7 @@
 name: 'Build'
 
 env:
-  VERSION: 3.6.1
+  VERSION: 3.6.2
   BUILD_TYPE: Release
   ARCH: x64
   VCPKG_CONFIG: Release

diff --git a/bt/app/browser.cpp b/bt/app/browser.cpp
@@ -228,7 +228,7 @@ namespace bt {
         }
 
         //win32::shell::exec(b->open_cmd, arg);
-        win32::process::start(b->open_cmd + " " + arg);
+        win32::process::start(b->open_cmd + " " + arg, false);
     }
 
     bool browser_instance::is_match(const url_payload& up, match_rule& mr) const {

diff --git a/common b/common
diff --git a/docs/release-notes.md b/docs/release-notes.md
@@ -1,3 +1,7 @@
+## 3.6.2
+
+🐞Fixed: BT hangs waiting for browser proxy process to terminate. Thanks to @cjs1976 and @fixator10 in #51.
+
 ## 3.6.1
 
 🐞Fixed: when external monitor is set as primary, picker is shown on a wrong monitor. Thanks to @ianzhuo in #48.