-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opus format with Ogg codec for BufferStream #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BufferType to use in
setBufferStream
, now support alsoopus
as data type. When adding audio chunks usingaddAudioDataStream
using Opus, it now expects to receive a stream of an Opus file.This can be useful for example when you have a stream coming from a network and you want to play it in real-time. Tested with the Opus coming from OpenAI's Text-To-Speech APIs.
To achieve this I've used Xiph Ogg and Opus libraries.
working on
Use external Xiph libraries where possible:
This means the
opus
andogg
libraries are embedded in iOS, Android, and Windows. On MacOS and Linux, you should install them withbrew install libogg opus
or with your distribution's package manager. If not installed, it compiles anyway, but it will throw if you want to use the opus streaming feature.To avoid future incompatibilities when using other WASM compiled plugins, it is now necessary to add
init_module.dart.js
script toindex.html
:By default when compiling a WASM library the default name for the JS module is
Module
and AFAIK only one can exist. Now the module name is calledModule_soloud
and it needs to be initialized.Type of Change