-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create endpoint and formatter for gather cms data #142
Merged
joyet-simon
merged 7 commits into
develop
from
feature/ecom-2116-php-client-create-endpoint-that-returns-data
Oct 22, 2024
Merged
Create endpoint and formatter for gather cms data #142
joyet-simon
merged 7 commits into
develop
from
feature/ecom-2116-php-client-create-endpoint-that-returns-data
Oct 22, 2024
+675
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francois-Gomis
requested changes
Oct 17, 2024
Benjamin-Freoua-Alma
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments has been see in mob review :)
Francois-Gomis
approved these changes
Oct 18, 2024
Benjamin-Freoua-Alma
approved these changes
Oct 21, 2024
Quality Gate failedFailed conditions |
Francois-Gomis
approved these changes
Oct 22, 2024
Benjamin-Freoua-Alma
approved these changes
Oct 22, 2024
joyet-simon
deleted the
feature/ecom-2116-php-client-create-endpoint-that-returns-data
branch
October 22, 2024 07:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
We need to implement new endpoint to save an url for gathering CMS data.
Code changes
How to test
As a reviewer, you are encouraged to test the PR locally.
You can run unit tests
Checklist for authors and reviewers
Non applicable