Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shipment data endpoint #127

Conversation

Francois-Gomis
Copy link
Collaborator

Reason for change

https://linear.app/almapay/issue/ECOM-1911/[php-client]-change-shipment-data-requirement-and-url

Linear task

Code changes

Change endpoint updateTracking endpoint to addTracking

How to test

Use integration tests
As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Francois-Gomis Francois-Gomis requested a review from a team as a code owner July 24, 2024 12:57
@Francois-Gomis Francois-Gomis added the minor A new minor version will be created for next release label Jul 26, 2024
@Francois-Gomis Francois-Gomis force-pushed the feature/ecom-1911-php-client-change-shipment-data-requirement-and-url branch from c6c8c7a to 3b1e8e9 Compare July 26, 2024 15:16
Copy link

@Francois-Gomis Francois-Gomis merged commit 9912ead into develop Jul 26, 2024
17 of 23 checks passed
@Francois-Gomis Francois-Gomis deleted the feature/ecom-1911-php-client-change-shipment-data-requirement-and-url branch July 29, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor A new minor version will be created for next release type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants