-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider
): instantiate recommended fillers by default
#1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
changed the title
Yash/default recommended fillers
feat(Jan 8, 2025
provider
): instantiate recommended fillers by default
gakonst
reviewed
Jan 8, 2025
gakonst
reviewed
Jan 8, 2025
yash-atreya
requested review from
DaniPopes,
mattsse,
onbjerg and
klkvr
as code owners
January 8, 2025 17:20
DaniPopes
reviewed
Jan 8, 2025
DaniPopes
reviewed
Jan 9, 2025
DaniPopes
approved these changes
Jan 9, 2025
DaniPopes
reviewed
Jan 10, 2025
DaniPopes
approved these changes
Jan 10, 2025
mattsse
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Instantiate
RecommendedFillers
by default.Solution
RecommededFillers
are added when theProviderBuilder
is instantiated usingnew()
i.eProviderBuilder::new()
will now returnFillProvider
with the recommended fillers instantiated..disable_recommended_fillers()
.For example, if a user want just wants
cached_nonce_management
. It can be achieved like so:PR Checklist