Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(consensus): move Header::size into trait BlockHeader #1414

Closed
wants to merge 1 commit into from
Closed

chore(consensus): move Header::size into trait BlockHeader #1414

wants to merge 1 commit into from

Conversation

emhane
Copy link
Contributor

@emhane emhane commented Oct 2, 2024

Motivation

Header::size must be accessible via abstraction BlockHeader in reth sdk

Solution

Move Header::size into trait method of BlockHeader

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane added the debt Tech debt which needs to be addressed label Oct 2, 2024
@emhane emhane mentioned this pull request Oct 2, 2024
Closed
3 tasks
mattsse
mattsse reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this feels a bit odd to make it part of the blockheader trait because this is something entirely unrelated.

@emhane emhane closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse