Fixes for OnPlayerTeleport hook for linux and linux64 systems #2234
Conversation
- Changed signature call of `CanPlayerTeleport` for linux/linux64 to current used name - Applied fix at detour class CanPlayerBeTeleported to use standard parameter proceedings for linux
Update on branch.
Update with master branch.
There was a problem hiding this comment.
Thanks for following up on this! Can we change the gamedata update to instead use a new name for this, leaving the original one as-is? Otherwise, if we push the updated gamedata to the gamedata updater without users necessarily having manually updated SourceMod, there will be a mismatch between what function variant the code is targeting versus what the gamedata is targeting.
Should also add a comment to note why it was done, noting that the older one can be nuked later. |
…e obsolete for older Sourcemod versions.
|
Added a new registry for the teleportation checking and marked the old one as Obsolete. New registry is called |
* - Fixes for OnPlayerTeleport hook for linux and linux64 systems - Changed signature call of `CanPlayerTeleport` for linux/linux64 to current used name - Applied fix at detour class CanPlayerBeTeleported to use standard parameter proceedings for linux * Created a new registry for Teleportation Checking, marking the old one obsolete for older Sourcemod versions. (cherry picked from commit 52211de)
Merge #2214 failed due to pointer misalignment which was fixed in safetyhook and a revision commit was made, making the process of hooking work normally again.
Tests were made on Linux with bare MM+SM installations, MM+SM+many dummy plugins using different hooks and both mock and production servers , and no recurring crashes were reported.
Tests were also made on Windows, both with MM+SM installations and MM+SM+dummy hook plugins.
Pull request fixes issue #2140.