-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated memmap_dtype to automatically choose based on vocab size #795
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think you misunderstood. What we want is, set the dtype based on the vocab size. If the vocab size is > 2**16
, then the dtype has to be uint32
. If it's smaller, it has to be uint16
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog is no longer accurate.
But my main question is, what happens when someone overrides the setting? Is that possible? It should be.
There is still data_config.effective_memmap_dtype
. Where does that come from? Do we have to respect if it's set?
Updated
memmap_dtype
to uint32 for compatibility with OLMo-2-1124.Added links to the Discord and Playground in the readme.
Minor improvements in readme.