Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed cell masking and closed loader error message by updating w3cv dependency #222

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

ShrimpCryptid
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid commented Dec 5, 2024

Problem

Closes #216 ("Cell masking doesn't reset when switching between XY views") and #220 ("Error: Tried to use a closed loader when switching between XY modes")

I tested it locally and both issues have been resolved! Huge thank you to @toloudis for doing the bug hunting for #220.

Solution

  • Updates w3cv dependency to use the new patched version!

@ShrimpCryptid ShrimpCryptid self-assigned this Dec 5, 2024
@ShrimpCryptid ShrimpCryptid marked this pull request as ready for review December 5, 2024 23:31
@ShrimpCryptid ShrimpCryptid requested a review from a team as a code owner December 5, 2024 23:31
@ShrimpCryptid ShrimpCryptid merged commit 51a5c34 into main Dec 6, 2024
1 check passed
@ShrimpCryptid ShrimpCryptid deleted the fix/cell-masking-reset branch December 6, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cell masking doesn't reset when switching between XY views.
3 participants