feature: Mock image dataset for CSV loading (CSV pt. 1) #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShrimpCryptid
force-pushed
the
feature/csv-loader-1
branch
from
b5c8da2 to
439128a
Compare
ShrimpCryptid
force-pushed
the
feature/csv-loader-1
branch
from
439128a to
eb07195
Compare
ShrimpCryptid
commented
Nov 14, 2024
| @@ -0,0 +1,39 @@ | |||
| import { expect } from "chai"; | |||
There was a problem hiding this comment.
Unit tests are purposefully very basic right now! Will be adding more robust checks in a future PR.
ShrimpCryptid
requested review from
interim17 and
ascibisz
and removed request for
a team
ShrimpCryptid
changed the title
kmitcham
reviewed
Nov 19, 2024
kmitcham
reviewed
Nov 19, 2024
kmitcham
reviewed
Nov 19, 2024
kmitcham
reviewed
Nov 19, 2024
| * - Check for behavior when there is no discrete feature column -> validate groupby | ||
| * - Check for handling of BFF-specific column names (they should be remapped) | ||
| * - Check that metadata columns are parsed correctly | ||
| * - Check that metadata-related columns are not parsed as features |
There was a problem hiding this comment.
Check when cellIds collide with row numbers
kmitcham
approved these changes
Nov 19, 2024
interim17
approved these changes
Nov 19, 2024
Comment on lines
+6
to
+9
| "\npotato,https://example.com/1/raw.ome.zarr,https://example.com/1.png,1,2,3,A" + | ||
| "\ngarbanzo,https://example.com/2/raw.ome.zarr,https://example.com/2.jpeg,7,3.4,1,B" + | ||
| "\nturnip,https://example.com/3/raw.ome.zarr,https://example.com/3.jpeg,4,5,6,B" + | ||
| "\nrutabaga,https://example.com/4/raw.ome.zarr,https://example.com/4.jpeg,9,2.8,NaN,C"; |
interim17
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part 1 of around 2-3 PRs I'll be opening to complete #213, "load CSV data".
This PR is very bare-bones because I'm trying to keep my PRs at a more manageable size. The next PR will include more robust unit testing and handling for BFF-specific data formats.
Estimated review size: large, 30 minutes
Follow up PRs:
Solution
papaparseas a dependency.CsvRequest.Type of change