Skip to content

Commit

Permalink
Fix permissions
Browse files Browse the repository at this point in the history
  • Loading branch information
matyldv committed Apr 30, 2024
1 parent c5d72e6 commit 6543ef4
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/ralph/lib/mixins/tests/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ class AdminUrlTestCase(TestCase):
def test_returned_url(self):
obj = Foo.objects.create(bar='test')
self.assertEqual(
'/tests/foo/{}/'.format(obj.pk), obj.get_absolute_url()
'/tests/foo/{}/change/'.format(obj.pk), obj.get_absolute_url()
)
1 change: 1 addition & 0 deletions src/ralph/lib/permissions/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
default_app_config = 'ralph.lib.permissions.apps.PermissionAppConfig'
6 changes: 2 additions & 4 deletions src/ralph/lib/permissions/apps.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,14 @@
from django.apps import AppConfig
from django.db.models.signals import post_migrate

from ralph.lib.permissions.models import create_permissions
from ralph.lib.permissions.views import update_extra_view_permissions


class PermissionAppConfig(AppConfig):
name = 'ralph.lib.permissions'
verbose_name = 'Permissions'

def ready(self):
default_app_config = 'ralph.lib.permissions.apps.PermissionAppConfig'
from ralph.lib.permissions.models import create_permissions
from ralph.lib.permissions.views import update_extra_view_permissions
post_migrate.disconnect(
dispatch_uid='django.contrib.auth.management.create_permissions'
)
Expand Down
5 changes: 3 additions & 2 deletions src/ralph/lib/permissions/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ def update_extra_view_permissions(sender, **kwargs):
logger.info('Updating extra views permissions...')
admin_classes = {}
for model, admin_class in ralph_site._registry.items():
for change_view in admin_class.change_views:
admin_classes[change_view] = model
if admin_class.change_views:
for change_view in admin_class.change_views:
admin_classes[change_view] = model

old_permission = Permission.objects.filter(
codename__startswith='can_view_extra_'
Expand Down
2 changes: 1 addition & 1 deletion src/ralph/virtual/management/commands/openstack_sync.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from enum import auto, Enum
from functools import lru_cache

import reversion as revisions
from reversion import revisions
from django.conf import settings
from django.core.exceptions import MultipleObjectsReturned, ObjectDoesNotExist
from django.core.management.base import BaseCommand
Expand Down

0 comments on commit 6543ef4

Please sign in to comment.