Fixed traffic splitting condition for cluster configuration

allegro · Dec 5, 2023 · e617418 · e617418
1 parent 1abb570
commit e617418
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,11 @@
 Lists all changes with user impact.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
+## [0.20.3]
+
+### Changed
+- Fixed traffic splitting condition check for cluster configuration
+
 ## [0.20.2]
 
 ### Changed

diff --git a/.../allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClustersFactory.kt b/.../allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClustersFactory.kt
@@ -304,7 +304,7 @@ class EnvoyClustersFactory(
         clusterLoadAssignment: ClusterLoadAssignment?,
         trafficSplitting: TrafficSplittingProperties
     ) = clusterLoadAssignment?.endpointsList
-        ?.any { e -> trafficSplitting.zoneName == e.locality.zone } ?: false
+        ?.any { e -> trafficSplitting.zoneName == e.locality.zone && e.lbEndpointsCount > 0 } ?: false
 
     private fun shouldAddDynamicForwardProxyCluster(group: Group) =
         group.proxySettings.outgoing.getDomainPatternDependencies().isNotEmpty()