You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But, running npx all-contributors-cli add ... is adding commitConvention or repoType properties with their default values to .all-contributorsrc files that don't have them explicitly.
Describe the bug
.all-contributorsrc
files shouldn't need to includecommitConvention
orrepoType
properties. They both have default values as documented on https://allcontributors.org/docs/en/bot/configuration:commitConvention
:"angular"
repoType
:"github"
But, running
npx all-contributors-cli add ...
is addingcommitConvention
orrepoType
properties with their default values to.all-contributorsrc
files that don't have them explicitly.To Reproduce
See https://github.com/JoshuaKGoldberg/repros/tree/all-contributors-cli-add-field-defaults.
.all-contributorsrc
npx all-contributors-cli add JoshuaKGoldberg doc
Expected behavior
The
.all-contributorsrc
file shouldn't havecommitConvention
orrepoType
added, since they have documented defaults.Additional context
I filed a bunch of feature requests over on https://github.com/all-contributors/all-contributors for more default-friendly behavior. all-contributors/all-contributors#808 is something of a hub for them.
The text was updated successfully, but these errors were encountered: