Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for python #5736

Merged
merged 5 commits into from
Jan 17, 2025
Merged

fix for python #5736

merged 5 commits into from
Jan 17, 2025

Conversation

sy-c
Copy link
Contributor

@sy-c sy-c commented Jan 16, 2025

No description provided.

@sy-c sy-c requested a review from a team as a code owner January 16, 2025 10:34
@sy-c
Copy link
Contributor Author

sy-c commented Jan 16, 2025

A previous alidist PR (#5709) broke compilation of lla and readoucard libraries with python support.
https://its.cern.ch/jira/browse/ORC-502

@vascobarroso vascobarroso enabled auto-merge (squash) January 16, 2025 10:41
vascobarroso
vascobarroso previously approved these changes Jan 16, 2025
@vascobarroso vascobarroso disabled auto-merge January 16, 2025 13:57
@vascobarroso vascobarroso enabled auto-merge (squash) January 16, 2025 15:07
@Barthelemy
Copy link
Contributor

The RPMs generation breaks with the proposed changes. The difference with the checkers here is that we use --always-prefer-system.
To fix it, you can add ${PYTHON_ROOT:+-DPython3_EXECUTABLE="$(which python3)"} \ to the alf.sh recipe (in the cmake parameters).

@sy-c
Copy link
Contributor Author

sy-c commented Jan 17, 2025

Indeed, alf was not updated. It is strange that it worked at all before, as python was not even mentionned in the CMake args so far for this module. The grep was no enough.

@vascobarroso vascobarroso self-requested a review January 17, 2025 11:30
@vascobarroso vascobarroso disabled auto-merge January 17, 2025 11:31
@vascobarroso vascobarroso merged commit 79a3407 into master Jan 17, 2025
14 of 15 checks passed
@vascobarroso vascobarroso deleted the sy-c-patch-1 branch January 17, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants