Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spellcheck #1779

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Fix Spellcheck #1779

merged 5 commits into from
Oct 14, 2024

Conversation

Seb-MCaw
Copy link
Contributor

@Seb-MCaw Seb-MCaw commented Oct 14, 2024

Closes #1776

The spellcheck check now has what I'm guessing is the intended behaviour:

Let me know if I have guessed incorrectly.

@Seb-MCaw Seb-MCaw force-pushed the fix/spellcheck branch 2 times, most recently from 0a60c2f to 7f12a3f Compare October 14, 2024 08:15
@Seb-MCaw Seb-MCaw marked this pull request as ready for review October 14, 2024 09:31
@mosteo
Copy link
Member

mosteo commented Oct 14, 2024

Your assessment is correct.

The pull_request_trigger considerations I think would be safe in this instance, but it doesn't seem important enough to open that can of worms.

@mosteo mosteo merged commit ad83bb5 into alire-project:master Oct 14, 2024
24 checks passed
@Seb-MCaw Seb-MCaw deleted the fix/spellcheck branch October 14, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spellcheck does not fail when there are typos
2 participants