Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support user defined config path #350

Merged

Conversation

xiatiandeairen
Copy link
Contributor

No description provided.

@alichtman
Copy link
Owner

alichtman commented Feb 8, 2025

This seems like a reasonable feature. Can you test that this works for you? I added a commit on top of yours containing the changes required to get this merged

@xiatiandeairen
Copy link
Contributor Author

This seems like a reasonable feature. Can you test that this works for you? I added a commit on top of yours containing the changes required to get this merged

get, i will at u after i test done

@xiatiandeairen
Copy link
Contributor Author

@alichtman test done, it works

@alichtman
Copy link
Owner

Please run black for code formatting, then we're good to go

@xiatiandeairen
Copy link
Contributor Author

Please run black for code formatting, then we're good to go

looks like i have to sign for commit, but actually not. i will fix it later

@xiatiandeairen xiatiandeairen force-pushed the p/xiatian/support_custom_config_path branch from 3c7e007 to 9ae66c7 Compare February 13, 2025 14:40
@xiatiandeairen
Copy link
Contributor Author

@alichtman please approve pr

@alichtman alichtman merged commit e7d3bf9 into alichtman:main Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants