Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask processing node #2658

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Mask processing node #2658

merged 1 commit into from
Jan 31, 2025

Conversation

servantftechnicolor
Copy link
Contributor

@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.95%. Comparing base (bd2b892) to head (fad39ee).
Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
meshroom/nodes/aliceVision/MaskProcessing.py 68.18% 7 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2658      +/-   ##
===========================================
+ Coverage    69.93%   69.95%   +0.01%     
===========================================
  Files          121      122       +1     
  Lines         7088     7106      +18     
===========================================
+ Hits          4957     4971      +14     
- Misses        2131     2135       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fabiencastan
fabiencastan reviewed Jan 28, 2025
View reviewed changes
meshroom/nodes/aliceVision/MaskProcessing.py Outdated
label="Output",
description="Path to the output directory.",
value=desc.Node.internalFolder,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to expose the output masks to the Viewer.
Here is an example: https://github.com/alicevision/Meshroom/blob/develop/meshroom/nodes/aliceVision/ImageSegmentation.py#L86

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to expose the output masks to the Viewer. Here is an example: https://github.com/alicevision/Meshroom/blob/develop/meshroom/nodes/aliceVision/ImageSegmentation.py#L86

How do i do that ? I have no clue about the masks names as it may come from various sources.

@fabiencastan fabiencastan added this to the Meshroom 2025.1.0 milestone Jan 31, 2025
@fabiencastan fabiencastan merged commit 91885af into develop Jan 31, 2025
4 of 5 checks passed
@fabiencastan fabiencastan deleted the dev/maskProcessing branch January 31, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Meshroom 2025.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@servantftechnicolor @fabiencastan