Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up .clang-tidy and apply camelBack case on functions and variables for some modules #1637

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Jan 4, 2024

Description

This PR updates the .clang-tidy file to detect instances where the case used for a variable/function/class/structure differs from the following:

  • camelBack for functions and variables;
  • CamelCase for classes and structures.

Using that file, the following modules have been updated to respect these rules:

  • sfmDataIO: in particular, the Load/Save functions have been renamed to respect camelBack case
  • image: in particular, accesses to the width and height, which are used across all the project, have been renamed to respect camelBack case; "convertion.hpp" and "convertionOpenCV.hpp" have also been renamed to fix the typo in the filenames
  • sfm: functions as well as variables within these functions' definitions have been heavily renamed to respect camelBack case

The modifications are not exhaustive and do not fix all the warnings generated by clang-tidy but intend to start harmonizing globally the code.

This pull request presents no functional change.

This relates to alicevision/QtAliceVision#66.

@cbentejac cbentejac added this to the 3.3.0 milestone Jan 4, 2024
@cbentejac cbentejac self-assigned this Jan 4, 2024
@cbentejac cbentejac force-pushed the dev/clangTidy branch 2 times, most recently from c07ea28 to 2671463 Compare January 4, 2024 17:58
@cbentejac cbentejac marked this pull request as draft January 4, 2024 18:22
@cbentejac cbentejac marked this pull request as ready for review January 8, 2024 11:56
@fabiencastan fabiencastan merged commit 9968586 into develop Jan 10, 2024
4 checks passed
@fabiencastan fabiencastan deleted the dev/clangTidy branch January 10, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants