Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential github action smells #3402

Open
wants to merge 2 commits into
base: 1.8
Choose a base branch
from
Open

Fix potential github action smells #3402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
665d2da
Fix gha smells:
ceddy4395 May 24, 2024
4128538
Put lifecycle phase at end of mvn command to test for windows
ceddy4395 May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@ on:

jobs:
build:
runs-on: ubuntu-latest
name: Build on ${{matrix.os}} with Java ${{matrix.java}}
runs-on: ${{matrix.os}}
strategy:
fail-fast: false
matrix:
java: [8, 11, 17, 21]
os: [ubuntu-latest, windows-latest]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -36,15 +39,15 @@ jobs:
distribution: 'temurin'

- name: Maven Test With Spring 6.x
run: mvn --batch-mode test -Dsurefire.jdk-toolchain-version=${{ matrix.java }}
run: mvn test --batch-mode "-Dsurefire.jdk-toolchain-version=${{ matrix.java }}"
if: ${{ matrix.java >= 17 }}

- name: Maven Test Without Spring 6.x
run: mvn --batch-mode test -Dsurefire.jdk-toolchain-version=${{ matrix.java }} -Dskip.spring.v6x.test=true
run: mvn test --batch-mode "-Dsurefire.jdk-toolchain-version=${{ matrix.java }}" "-Dskip.spring.v6x.test=true"
if: ${{ matrix.java < 17 }}

- name: Build with Maven
run: mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V -DminimumPriority=1
run: mvn install "-DskipTests=true" "-Dmaven.javadoc.skip=true" -B -V "-DminimumPriority=1"

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v4.0.1
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/document-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- run: npm install -g markdownlint-cli

- run: npm install -g markdownlint-cli@0.40.0
# Run markdown lint with the following rules disabled:
# no hard tabs, line length, no duplicate heading, ordered list item prefix, no inline html and no emphasis as heading
- name: use markdownlint-cli to lint markdown file
run: |
find ./ -name "*.md" | grep -v vendor | grep -v commandline | grep -v .github | grep -v swagger | grep -v api | \
Expand Down