Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stream-messenger/messenger.h from include #519

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Remove stream-messenger/messenger.h from include #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/docs/introduction/how-to-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ The examples and test code are built together.

```bash
# Install additional dependencies
dnf install epel-releaase
dnf config-manager --set-enabled PowerTools
dnf install epel-release
dnf config-manager --set-enabled powertools
dnf install gtest-devel gmock-devel gflags-devel fuse-devel libgsasl-devel

# Build examples and test code
Expand Down
4 changes: 2 additions & 2 deletions doc/i18n/cn/docusaurus-plugin-content-docs/current/introduction/how-to-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ cmake --build build -j 8

```bash
# Install additional dependencies
dnf install epel-releaase
dnf config-manager --set-enabled PowerTools
dnf install epel-release
dnf config-manager --set-enabled powertools
dnf install gtest-devel gmock-devel gflags-devel fuse-devel libgsasl-devel

# Build examples and test code
Expand Down
1 change: 0 additions & 1 deletion include/photon/common/stream-messenger/messenger.h
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion io/iouring-wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class iouringEngine : public MasterEventEngine, public CascadingEventEngine, pub
// reset m_ring so that the destructor won't do duplicate munmap cleanup (io_uring_queue_exit)
delete m_ring;
m_ring = nullptr;
LOG_ERRNO_RETURN(0, -1, "iouring: failed to init queue");
LOG_ERROR_RETURN(0, -1, "iouring: failed to init queue: ", ERRNO(-ret));
}

// Check feature supported
Expand Down
4 changes: 2 additions & 2 deletions thread/std-compat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,8 @@ class condition_variable : public photon::condition_variable {
return cv_status::no_timeout;
// We got a timeout when measured against photon's internal clock,
// but we need to check against the caller-supplied clock to tell whether we should return a timeout.
if (Clock::now() < t)
return cv_status::no_timeout;
// if (Clock::now() < t)
// return cv_status::no_timeout;
return cv_status::timeout;
}
Copy link
Collaborator Author

@beef9999 beef9999 Jun 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CI random error:

photon timeout may return earlier. Don't need to compare with steady clock.


Expand Down
Loading